[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9fd57e4d4888: [clang] Support vectors in __builtin_isfpclass (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

sepavloff updated this revision to Diff 554750. sepavloff added a comment. Update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153339/new/ https://reviews.llvm.org/D153339 Files: clang/docs/LanguageExtensions.rst

[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Changes LGTM, but should come with a release note. Comment at: clang/docs/LanguageExtensions.rst:3543-3544 the floating-point value, specified by the first

[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

sepavloff updated this revision to Diff 553960. sepavloff added a comment. Fix documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153339/new/ https://reviews.llvm.org/D153339 Files: clang/docs/LanguageExtensions.rst

[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

sepavloff added a comment. In D153339#4489025 , @aaron.ballman wrote: > This seems reasonable to me, but I do wonder if changing the return type from > int to bool will cause surprises for anyone. I see why it's done, but this > seems more like a C

[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

sepavloff updated this revision to Diff 553908. sepavloff added a comment. Herald added a subscriber: sunshaoce. Use representation of logical vectors similar to OpenCL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153339/new/

[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

aaron.ballman added a comment. This seems reasonable to me, but I do wonder if changing the return type from int to bool will cause surprises for anyone. I see why it's done, but this seems more like a C interface (to me) which would return an `int`; returning a `bool` gets promoted to `int`

[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153339/new/ https://reviews.llvm.org/D153339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

sepavloff created this revision. sepavloff added reviewers: rjmccall, aaron.ballman, arsenm, kpn, qiucf, efriedma. Herald added a project: All. sepavloff requested review of this revision. Herald added a subscriber: wdng. Herald added a project: clang. Builtin function `__builtin_isfpclass` now