[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

2023-06-29 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 closed this revision. jyu2 added a comment. Checked in with rG085845a2acbe CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153556/new/ https://reviews.llvm.org/D153556

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

2023-06-29 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153556/new/ https://reviews.llvm.org/D153556 ___ cfe-commits mailing list

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

2023-06-29 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 535794. jyu2 added a comment. Sorry, full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153556/new/ https://reviews.llvm.org/D153556 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/RecursiveASTVisitor.h

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

2023-06-29 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:20871 TotalDepCount.getZExtValue()); + if ((DepKind == OMPC_DEPEND_sink || DepKind == OMPC_DEPEND_source) && Remove this new line Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

2023-06-29 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. Upload full context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153556/new/ https://reviews.llvm.org/D153556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

2023-06-28 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added a comment. Thanks. Comment at: clang/lib/Parse/ParseOpenMP.cpp:4415-4439 + } else if (Kind == OMPC_doacross) { +// Handle dependence type for the doacross clause. +ColonProtectionRAIIObject ColonRAII(*this); +Data.ExtraModifier =

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

2023-06-28 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 535601. jyu2 added a comment. Thanks Alexey's review. This is address his comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153556/new/ https://reviews.llvm.org/D153556 Files:

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

2023-06-28 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:4415-4439 + } else if (Kind == OMPC_doacross) { +// Handle dependence type for the doacross clause. +ColonProtectionRAIIObject ColonRAII(*this); +Data.ExtraModifier =

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

2023-06-28 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added a comment. Thanks Alexey for the review. Comment at: clang/lib/Parse/ParseOpenMP.cpp:4415-4439 + } else if (Kind == OMPC_doacross) { +// Handle dependence type for the doacross clause. +ColonProtectionRAIIObject ColonRAII(*this); +Data.ExtraModifier =

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

2023-06-28 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 535289. jyu2 added a comment. Thanks Alex for the review. This is to address his comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153556/new/ https://reviews.llvm.org/D153556 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

2023-06-27 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:4415-4439 + } else if (Kind == OMPC_doacross) { +// Handle dependence type for the doacross clause. +ColonProtectionRAIIObject ColonRAII(*this); +Data.ExtraModifier =

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

2023-06-22 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert, mikerice. jyu2 added projects: OpenMP, clang. Herald added subscribers: sunshaoce, arphaman, guansong, yaxunl. Herald added a reviewer: kiranchandramohan. Herald added projects: Flang, All. jyu2 requested review of this