[PATCH] D153585: [clang-format] Fix align consecutive declarations over function pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa84e0b4bdc99: [clang-format] Fix align consecutive declarations over function pointers (authored by gedare, committed by owenpan). Changed prior to

[PATCH] D153585: [clang-format] Fix align consecutive declarations over function pointers

gedare updated this revision to Diff 537359. gedare added a comment. Merge the two if statements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153585/new/ https://reviews.llvm.org/D153585 Files: clang/lib/Format/WhitespaceManager.cpp

[PATCH] D153585: [clang-format] Fix align consecutive declarations over function pointers

owenpan added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:869-871 if (C.Tok->is(TT_FunctionDeclarationName)) return true; +if (C.Tok->is(TT_FunctionTypeLParen)) We should merge the two `if` statements.

[PATCH] D153585: [clang-format] Fix align consecutive declarations over function pointers

MyDeveloperDay added a comment. Can you reference the GitHub bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153585/new/ https://reviews.llvm.org/D153585 ___ cfe-commits mailing list

[PATCH] D153585: [clang-format] Fix align consecutive declarations over function pointers

gedare added a comment. I'm not sure how to properly stack dependent revs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153585/new/ https://reviews.llvm.org/D153585 ___ cfe-commits mailing list

[PATCH] D153585: [clang-format] Fix align consecutive declarations over function pointers

gedare added a comment. Split this out from D153579 . This requires D153579 first, for the test cases to pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153585/new/

[PATCH] D153585: [clang-format] Fix align consecutive declarations over function pointers

gedare created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. gedare requested review of this revision. Fixes a bug that prevents alignment from proceeding through