[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

zahiraam added a comment. In D153590#4446358 , @mgorny wrote: > This change causes test regressions on 32-bit x86: > > FAIL: Clang :: Sema/fp-eval-pragma-with-float-double_t-3.c (14665 of 17845) > TEST 'Clang :: >

[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

mgorny added a comment. This change causes test regressions on 32-bit x86: FAIL: Clang :: Sema/fp-eval-pragma-with-float-double_t-3.c (14665 of 17845) TEST 'Clang :: Sema/fp-eval-pragma-with-float-double_t-3.c' FAILED Script: -- : 'RUN: at

[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

This revision was automatically updated to reflect the committed changes. Closed by commit rG63b0b82fd6be: When float_t and double_t types are used inside a scope with (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153590/new/

[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153590/new/ https://reviews.llvm.org/D153590 ___ cfe-commits mailing list

[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

zahiraam updated this revision to Diff 533981. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153590/new/ https://reviews.llvm.org/D153590 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

rjmccall added a comment. `abi-check` is a really generic name for a test case; could you rename those three tests to something more specific to this feature? Also, your tests are only testing this behavior in C++. Patch functionality LGTM. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

zahiraam created this revision. zahiraam added reviewers: rjmccall, andrew.w.kaylor, aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. When float_t and double_t types are used inside a scope