[PATCH] D153623: [clang][Sema] Add fixit for scoped enum format error

2023-07-26 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Sorry for the delayed comment here. The fix-it is convenient, but is it the best suggestion? It'll end up suggesting truncating the enum value instead of using the proper format specifier in https://godbolt.org/z/xdhrefG95, for example. More insidiously, the `static_ca

[PATCH] D153623: [clang][Sema] Add fixit for scoped enum format error

2023-07-14 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb added a comment. Sorry, forgot to come back and LGTM, but it did indeed LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153623/new/ https://reviews.llvm.org/D153623 ___ cfe-commits mailing list

[PATCH] D153623: [clang][Sema] Add fixit for scoped enum format error

2023-07-14 Thread Alex Brachet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG563a23c824db: [clang][Sema] Add fixit for scoped enum format error (authored by abrachet). Herald added a project: clang. Herald added a subscriber: