[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

donat.nagy added a comment. When I tried to compile with gcc 7.5 after your fix commit (2f7d30dee826 ), I got another very similar compilation error from a different location and I pushed commit cec30e2b190b

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

donat.nagy added a comment. Thank you for the fix :) ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153674/new/ https://reviews.llvm.org/D153674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

zixuan-wu added a comment. In D153674#4461195 , @sammccall wrote: > Sorry about the delay, and thanks for the `.i`. > > It took me a while to work out what was going on, but it looks like it's just > a bug where GCC forgets to automatic-move. > Fixed in

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

sammccall added a comment. Sorry about the delay, and thanks for the `.i`. It took me a while to work out what was going on, but it looks like it's just a bug where GCC forgets to automatic-move. Fixed in 2f7d30dee8262746c3e8ee1f6f25be8c1ace9990

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

donat.nagy added a comment. I'm also using `gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0` (which supported according to the LLVM "Getting Started" page ) and I see the same std::optional compilation errors. Please

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

zixuan-wu added a comment. In D153674#4455357 , @sammccall wrote: > Hi, sorry about that - are you able to provide a full log, or link to a > failing bot? > That error message doesn't show where in the LLVM code the error occurs. It can pass with gcc 8.

Re: [PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

Hi, sorry about that - are you able to provide a full log, or link to a failing bot? That error message doesn't show where in the LLVM code the error occurs. On Wed, Jun 28, 2023 at 7:52 AM Zixuan Wu via Phabricator < revi...@reviews.llvm.org> wrote: > zixuan-wu added a comment. > > Hi, there is

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

zixuan-wu added a comment. Hi, there is a compiling error introduced recently as like following when files under clang/lib/Analysis/FlowSensitive/ are being compiled such as TypeErasedDataflowAnalysis.cpp and Transfer.cpp. Does anybody meet also? > from /usr/include/c++/7/functional:60, >

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2bb68078eb9: [dataflow] Disallow implicit copy of Environment, use fork() instead (authored by sammccall). Changed prior to commit:

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

xazax.hun accepted this revision. xazax.hun added a comment. Nice, looks like this change did catch some unintentional copies! Already paying dividends :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153674/new/ https://reviews.llvm.org/D153674

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

sammccall added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:211 PostVisitCFG(Element, DataflowAnalysisState{ -*Lattice, State.Env}); +*Lattice,

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

sammccall created this revision. sammccall added reviewers: xazax.hun, ymandel. Herald added a subscriber: martong. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.