This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
tbaeder marked 3 inline comments as done.
Closed by commit rG89361e2b98a9: [clang][Interp] Fix passing parameters of
composite type (authored by tbaeder).
Changed
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with debugging code removed and comments cleaned up.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153695/new/
tbaeder marked 3 inline comments as done.
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeEmitter.h:71
- /// Parameter indices.
- llvm::DenseMap Params;
+ /// Parameter indices. >
+ llvm::DenseMap Params;
shafik wrote:
> I don't
shafik added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeEmitter.h:71
- /// Parameter indices.
- llvm::DenseMap Params;
+ /// Parameter indices. >
+ llvm::DenseMap Params;
I don't understand the additional comment,
Comment
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
We pass these as pointers, so we need to be
