[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG09ed2102eab5: [clang-tidy] Fix modernize-use-std-print check when return value used (authored by mikecrowe, committed by

[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

mikecrowe requested review of this revision. mikecrowe added a comment. I believe that the problems that caused this to be reverted have been fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153860/new/ https://reviews.llvm.org/D153860

[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

mikecrowe updated this revision to Diff 535106. mikecrowe added a comment. Fix test failures on PS4 and PS5 and improve tests - Ensure that exceptions are available so the test can use try/catch - Remove unwanted -NOT checks - Add more return value tests Repository: rG LLVM Github Monorepo

[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

mikecrowe marked an inline comment as done. mikecrowe added a comment. In D153860#4453572 , @dyung wrote: > @mikecrowe Your change is causing a test failure on the PS4 linux and PS5 > Windows build bots. Can you take a look and fix or revert if you need

[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

dyung added a comment. @mikecrowe Your change is causing a test failure on the PS4 linux and PS5 Windows build bots. Can you take a look and fix or revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/139/builds/43856

[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e12b2e207cf: [clang-tidy] Fix modernize-use-std-print check when return value used (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

mikecrowe marked an inline comment as done. mikecrowe added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseStdPrintCheck.cpp:73-95 +static clang::ast_matchers::StatementMatcher +unusedReturnValue(clang::ast_matchers::StatementMatcher MatchedCallExpr) { +

[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clang-tidy/modernize/UseStdPrintCheck.cpp:73-95 +static clang::ast_matchers::StatementMatcher

[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

mikecrowe created this revision. mikecrowe added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a