This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe9877eca408e: [NFC] Initialize class member pointers to
nullptr. (authored by schittir).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
tahonermann accepted this revision.
tahonermann added a comment.
This revision is now accepted and ready to land.
Thanks, Sindhu! This looks good to me!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153892/new/
https://reviews.llvm.org/D153892
schittir updated this revision to Diff 538851.
schittir marked an inline comment as done.
schittir added a comment.
Fix format per comments - indent class members and avoid indenting the class
definition line.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153892/new/
tahonermann requested changes to this revision.
tahonermann added inline comments.
This revision now requires changes to proceed.
Herald added a subscriber: wangpc.
Comment at: clang/lib/Frontend/ASTConsumers.cpp:192-198
+ bool HandleTopLevelDecl(DeclGroupRef D) override {
schittir updated this revision to Diff 535459.
schittir added a comment.
Hope clang-format likes this patch!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153892/new/
https://reviews.llvm.org/D153892
Files:
clang/lib/ARCMigrate/TransProperties.cpp
clang/lib/AST/ExprConstant.cpp
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
Test failure is clang-format on ASTConsumers.cpp. Fix that please (whatever it
wants?) otherwise, LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
schittir created this revision.
schittir added reviewers: aaron.ballman, erichkeane, tahonermann.
Herald added subscribers: steakhal, martong.
Herald added a reviewer: NoQ.
Herald added a project: All.
schittir requested review of this revision.
Herald added a project: clang.
Herald added a
