This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG74258f4189e2: [C++20] [Modules] Allow Stmt::Profile to treat
ChuanqiXu added a comment.
I'd like to land this in the next week if no objections come in. Since clang-17
is going to be branched and this one is small and relevant. Also this one
prevents the testing of the std modules.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153957/new/
ChuanqiXu updated this revision to Diff 535664.
ChuanqiXu added a comment.
Address comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153957/new/
https://reviews.llvm.org/D153957
Files:
clang/include/clang/AST/Stmt.h
clang/lib/AST/ASTContext.cpp
shafik added inline comments.
Comment at: clang/lib/AST/StmtProfile.cpp:188
StmtProfilerWithoutPointers(llvm::FoldingSetNodeID , ODRHash )
-: StmtProfiler(ID, false), Hash(Hash) {}
+: StmtProfiler(ID, false, false), Hash(Hash) {}
nit
ChuanqiXu created this revision.
ChuanqiXu added reviewers: rsmith, cor3ntin, aaron.ballman, tbaeder.
ChuanqiXu added projects: clang-modules, clang-language-wg.
Herald added a project: All.
ChuanqiXu requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: