[PATCH] D153960: [clang][dataflow] Implement support for pointers to members.

mboehme added a comment. Pre-merge failure looks unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153960/new/ https://reviews.llvm.org/D153960 ___ cfe-commits mailing list

[PATCH] D153960: [clang][dataflow] Implement support for pointers to members.

mboehme added a comment. PTAL Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:447 - StorageLocation *PointeeLoc = Env.getStorageLocationStrict(*SubExpr); - if (PointeeLoc == nullptr) break; While I'm here, streamline the code for

[PATCH] D153960: [clang][dataflow] Implement support for pointers to members.

mboehme updated this revision to Diff 535401. mboehme marked an inline comment as done. mboehme added a comment. Don't produce values for pointers to members. For consistency, also make the NullToMemberPointer cast not produce any values. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D153960: [clang][dataflow] Implement support for pointers to members.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:236 +// `DeclRefExpr`s to fields and non-static methods aren't glvalues, and +// there's also no sensible `Value` we can assign to them, so

[PATCH] D153960: [clang][dataflow] Implement support for pointers to members.

mboehme added a comment. In D153960#4455661 , @gribozavr2 wrote: > Using PointerValue to model pointers to data members does not look right to > me, because a pointer to data member is an offset within an object that we > apply this pointer to, it is

[PATCH] D153960: [clang][dataflow] Implement support for pointers to members.

sammccall accepted this revision. sammccall added a comment. Per offline discussion, I think modelling pointer-to-member as PointerValue does make sense, though that's not completely obvious. Can we document this on PointerValue? (And that it points to a StorageLocation for the decl, which has

[PATCH] D153960: [clang][dataflow] Implement support for pointers to members.

gribozavr2 requested changes to this revision. gribozavr2 added a comment. This revision now requires changes to proceed. Using PointerValue to model pointers to data members does not look right to me, because a pointer to data member is an offset within an object that we apply this pointer to,

[PATCH] D153960: [clang][dataflow] Implement support for pointers to members.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The newly added tests crash without the other