probinson added a comment.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153993/new/
https://reviews.llvm.org/D153993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1461fabfb141: [Headers][doc] Add load/store/cmp/cvt
intrinsic descriptions to avx2intrin.h (authored by probinson).
Herald added a project: clang.
R
pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clang/lib/Headers/avx2intrin.h:3474
+/// IF __M[j+31] == 1
+/// result[j+31:j] := Load32(__X+(i*4))
+/// ELSE
probinson wrote:
>
probinson added inline comments.
Comment at: clang/lib/Headers/avx2intrin.h:3474
+/// IF __M[j+31] == 1
+/// result[j+31:j] := Load32(__X+(i*4))
+/// ELSE
pengfei wrote:
> probinson wrote:
> > pengfei wrote:
> > > probinson wrote:
> > > > pengfei wrote:
>
pengfei added inline comments.
Comment at: clang/lib/Headers/avx2intrin.h:3474
+/// IF __M[j+31] == 1
+/// result[j+31:j] := Load32(__X+(i*4))
+/// ELSE
probinson wrote:
> pengfei wrote:
> > probinson wrote:
> > > pengfei wrote:
> > > > A more intrinsic g
probinson added inline comments.
Comment at: clang/lib/Headers/avx2intrin.h:3474
+/// IF __M[j+31] == 1
+/// result[j+31:j] := Load32(__X+(i*4))
+/// ELSE
pengfei wrote:
> probinson wrote:
> > pengfei wrote:
> > > A more intrinsic guide format is `MEM[__X
pengfei added inline comments.
Comment at: clang/lib/Headers/avx2intrin.h:3474
+/// IF __M[j+31] == 1
+/// result[j+31:j] := Load32(__X+(i*4))
+/// ELSE
probinson wrote:
> pengfei wrote:
> > A more intrinsic guide format is `MEM[__X+j:j]`
> LoadXX is the
probinson updated this revision to Diff 535804.
probinson added a comment.
s/:7/:j/ correcting bit references.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153993/new/
https://reviews.llvm.org/D153993
Files:
clang/lib/Headers/avx2intrin.h
Index: clang/lib/Headers/avx2intrin.h
=
probinson added inline comments.
Comment at: clang/lib/Headers/avx2intrin.h:3474
+/// IF __M[j+31] == 1
+/// result[j+31:j] := Load32(__X+(i*4))
+/// ELSE
pengfei wrote:
> A more intrinsic guide format is `MEM[__X+j:j]`
LoadXX is the syntax in the gather
pengfei added inline comments.
Comment at: clang/lib/Headers/avx2intrin.h:1324
+/// k := i*16
+/// result[k+15:k] := SignExtend(__V[j+7:7])
+/// ENDFOR
j
Comment at: clang/lib/Headers/avx2intrin.h:1352
+/// k := i*32
+/// result[k+31:k]
probinson added a subscriber: cfe-commits.
probinson added a comment.
+ cfe-commits which didn't get added automatically.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153993/new/
https://reviews.llvm.org/D153993
___
cfe-commits mailing list
11 matches
Mail list logo