This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
benlangmuir marked an inline comment as done.
Closed by commit rG1ede7b47493f: [clang][modules] Avoid serializing all diag
mappings in non-deterministic order (authored
steven_wu accepted this revision.
steven_wu added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154016/new/
https://reviews.llvm.org/D154016
___
cfe-commits mailing list
cfe-com
benlangmuir marked an inline comment as done.
benlangmuir added inline comments.
Comment at: clang/lib/Serialization/ASTWriter.cpp:3016
for (const auto &I : *State) {
-if (I.second.isPragma() || IncludeNonPragmaStates) {
- Record.push_back(I.first);
-
benlangmuir updated this revision to Diff 535882.
benlangmuir added a comment.
Extended test to include diagnostic pragmas
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154016/new/
https://reviews.llvm.org/D154016
Files:
clang/include/clang/Basic/DiagnosticIDs.h
clang/lib/Basic/Dia
steven_wu added inline comments.
Comment at: clang/lib/Serialization/ASTWriter.cpp:3016
for (const auto &I : *State) {
-if (I.second.isPragma() || IncludeNonPragmaStates) {
- Record.push_back(I.first);
- Record.push_back(I.second.serialize());
-
benlangmuir created this revision.
benlangmuir added reviewers: steven_wu, jansvoboda11, akyrtzi.
Herald added a subscriber: mgrang.
Herald added a project: All.
benlangmuir requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
When writing a pcm
