[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG422bcd10c48b: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON (authored by evelez7). Changed prior to commit:

[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154038/new/ https://reviews.llvm.org/D154038 ___

[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

evelez7 updated this revision to Diff 536245. evelez7 marked an inline comment as done. evelez7 added a comment. Move semicolon line below After fragment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154038/new/ https://reviews.llvm.org/D154038

[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

dang added inline comments. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:437 .append(Var->getName(), DeclarationFragments::FragmentKind::Identifier) + .append(";", DeclarationFragments::FragmentKind::Text) .append(std::move(After));

[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

evelez7 added a comment. These updated tests pass locally for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154038/new/ https://reviews.llvm.org/D154038 ___ cfe-commits mailing list

[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

evelez7 created this revision. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a reviewer: dang. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo