[PATCH] D154123: [HIP] Start document HIP support by clang

This revision was automatically updated to reflect the committed changes. yaxunl marked 2 inline comments as done. Closed by commit rG795e934e15b7: [HIP] Start document HIP support by clang (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/docs/HIPSupport.rst:30 + +Clang provides partial HIP support on Intel GPUs using the CHIP-Star project ``_. CHIP-Star implements the HIP runtime over

[PATCH] D154123: [HIP] Start document HIP support by clang

keryell added inline comments. Comment at: clang/docs/HIPSupport.rst:30 + +Clang provides partial HIP support on Intel GPUs using the CHIP-Star project ``_. CHIP-Star implements the HIP runtime over oneAPI Level Zero or OpenCL runtime. The

[PATCH] D154123: [HIP] Start document HIP support by clang

scchan accepted this revision. scchan added a comment. This revision is now accepted and ready to land. LGTM thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154123/new/ https://reviews.llvm.org/D154123 ___ cfe-commits mailing list

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl updated this revision to Diff 543652. yaxunl marked an inline comment as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154123/new/ https://reviews.llvm.org/D154123 Files: clang/docs/HIPSupport.rst Index:

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/docs/HIPSupport.rst:65 + + clang++ --offload-arch=gfx906 -xhip sample.cpp -o sample + arsenm wrote: > scchan wrote: > > missing --hip-link > What does hip-link do? Why is

[PATCH] D154123: [HIP] Start document HIP support by clang

arsenm added inline comments. Comment at: clang/docs/HIPSupport.rst:65 + + clang++ --offload-arch=gfx906 -xhip sample.cpp -o sample + scchan wrote: > missing --hip-link What does hip-link do? Why is it needed? I never use it and it works CHANGES SINCE LAST

[PATCH] D154123: [HIP] Start document HIP support by clang

scchan added inline comments. Comment at: clang/docs/HIPSupport.rst:65 + + clang++ --offload-arch=gfx906 -xhip sample.cpp -o sample + missing --hip-link Comment at: clang/docs/HIPSupport.rst:77 + + clang++ --offload-arch=native -xhip

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154123/new/ https://reviews.llvm.org/D154123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl updated this revision to Diff 541028. yaxunl marked 4 inline comments as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154123/new/ https://reviews.llvm.org/D154123 Files: clang/docs/HIPSupport.rst Index:

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl marked 5 inline comments as done. yaxunl added inline comments. Comment at: clang/docs/HIPSupport.rst:24 + +Clang supports HIP on `ROCm platform `_. + keryell wrote: > keryell wrote: > > I thought the idea of HIP was

[PATCH] D154123: [HIP] Start document HIP support by clang

keryell added inline comments. Comment at: clang/docs/HIPSupport.rst:24 + +Clang supports HIP on `ROCm platform `_. + keryell wrote: > I thought the idea of HIP was to also target Nvidia GPU? Otherwise I do not >

[PATCH] D154123: [HIP] Start document HIP support by clang

keryell added inline comments. Comment at: clang/docs/HIPSupport.rst:24 + +Clang supports HIP on `ROCm platform `_. + I thought the idea of HIP was to also target Nvidia GPU? Otherwise I do not understand "portable

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl updated this revision to Diff 540485. yaxunl marked an inline comment as done. yaxunl edited the summary of this revision. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154123/new/ https://reviews.llvm.org/D154123 Files:

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/docs/HIPSupport.rst:33 + + clang -c --offload-arch=gfx906 -xhip test.cpp -o test.o + arsenm wrote: > Aren't you supposed to use clang++? Also, could show that .hip is

[PATCH] D154123: [HIP] Start document HIP support by clang

arsenm added inline comments. Comment at: clang/docs/HIPSupport.rst:33 + + clang -c --offload-arch=gfx906 -xhip test.cpp -o test.o + Aren't you supposed to use clang++? Also, could show that .hip is recognized? CHANGES SINCE LAST ACTION

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/docs/HIPSupport.rst:49 + +You can also use ``--offload-arch=native`` to let ``amdgpu-arch`` automatically detect the GPU architecture on your system: + arsenm wrote: >

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl updated this revision to Diff 540430. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154123/new/ https://reviews.llvm.org/D154123 Files: clang/docs/HIPSupport.rst Index: clang/docs/HIPSupport.rst

[PATCH] D154123: [HIP] Start document HIP support by clang

arsenm added inline comments. Comment at: clang/docs/HIPSupport.rst:49 + +You can also use ``--offload-arch=native`` to let ``amdgpu-arch`` automatically detect the GPU architecture on your system: + s/architecture/architectures Comment at:

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl updated this revision to Diff 538201. yaxunl marked an inline comment as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154123/new/ https://reviews.llvm.org/D154123 Files: clang/docs/HIPSupport.rst Index:

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/docs/HIPSupport.rst:82 +=== + +1. **Compiler Options**: If you specify paths using the compiler options, these will override the correponding paths set via

[PATCH] D154123: [HIP] Start document HIP support by clang

scchan added inline comments. Comment at: clang/docs/HIPSupport.rst:82 +=== + +1. **Compiler Options**: If you specify paths using the compiler options, these will override the correponding paths set via environment variables. I think

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl updated this revision to Diff 536231. yaxunl marked 4 inline comments as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154123/new/ https://reviews.llvm.org/D154123 Files: clang/docs/HIPSupport.rst Index:

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl marked 5 inline comments as done. yaxunl added inline comments. Comment at: clang/docs/HIPSupport.rst:33 + + clang -c --offload-arch=gfx906 test.hip -o test.o + scchan wrote: > can we add -xhip to enable HIP for files without the .hip file ext? will do

[PATCH] D154123: [HIP] Start document HIP support by clang

scchan added inline comments. Comment at: clang/docs/HIPSupport.rst:33 + + clang -c --offload-arch=gfx906 test.hip -o test.o + can we add -xhip to enable HIP for files without the .hip file ext? Comment at: clang/docs/HIPSupport.rst:56

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl added inline comments. Comment at: clang/docs/HIPSupport.rst:104 + - This macro is defined when the GPU default stream kind is set to per-thread. + b-sumner wrote: > Should we include the __gfxNNN__ or __GFXN__ macros here? What about wave > size,

[PATCH] D154123: [HIP] Start document HIP support by clang

b-sumner added inline comments. Comment at: clang/docs/HIPSupport.rst:104 + - This macro is defined when the GPU default stream kind is set to per-thread. + Should we include the __gfxNNN__ or __GFXN__ macros here? What about wave size, and CU mode? And

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl created this revision. yaxunl added reviewers: tra, scchan, b-sumner, arsenm. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: wdng. start with example usage, predefined macros and env vars. https://reviews.llvm.org/D154123 Files: