[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb026c9eb1051: [X86] Add missing features for ivybridge, sandybridge and knl in… (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

FreddyYe added a comment. In D154209#4466304 , @RKSimon wrote: > LGTM - but it would be good to fix silvermont / westmere cases as well with > suitable test coverage Thanks review! After D151696 landed, they can be bo

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - but it would be good to fix silvermont / westmere cases as well with suitable test coverage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

FreddyYe updated this revision to Diff 536495. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address comment, thanks review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154209/new/ https://reviews.llvm.org/D154209 Files:

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

craig.topper added inline comments. Comment at: llvm/include/llvm/TargetParser/X86TargetParser.def:275 CPU_SPECIFIC("core_5th_gen_avx_tsx", "broadwell", 'Y', "+cmov,+mmx,+sse,+sse2,+sse3,+ssse3,+sse4.1,+sse4.2,+movbe,+popcnt,+f16c,+avx,+fma,+bmi,+lzcnt,+avx2,+adx") -CPU_SPECIFI

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: llvm/include/llvm/TargetParser/X86TargetParser.def:262 CPU_SPECIFIC("core_i7_sse4_2", "nehalem", 'P', "+cmov,+mmx,+sse,+sse2,+sse3,+ssse3,+sse4.1,+sse4.2,+popcnt") CPU_SPECIFIC("core_aes_pcl

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

RKSimon added inline comments. Comment at: llvm/include/llvm/TargetParser/X86TargetParser.def:262 CPU_SPECIFIC("core_i7_sse4_2", "nehalem", 'P', "+cmov,+mmx,+sse,+sse2,+sse3,+ssse3,+sse4.1,+sse4.2,+popcnt") CPU_SPECIFIC("core_aes_pclmulqdq", "westmere", 'Q', "+cmov,+mmx,+sse,

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

FreddyYe created this revision. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is also a pre-commit change for D151696 Repository: rG LLVM