[PATCH] D154300: [CUDA][HIP] Fix template argument deduction

2023-08-08 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea72a4e6547f: [CUDA][HIP] Fix template argument deduction (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D154300: [CUDA][HIP] Fix template argument deduction

2023-08-07 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 547901. yaxunl marked an inline comment as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154300/new/ https://reviews.llvm.org/D154300 Files: clang/lib/Sema/SemaOverload.cpp

[PATCH] D154300: [CUDA][HIP] Fix template argument deduction

2023-08-07 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12758-12764 +std::optional MorePreferableByCUDA = +CheckCUDAPreference(FD, Result); +// If FD has different CUDA preference than Result.

[PATCH] D154300: [CUDA][HIP] Fix template argument deduction

2023-07-11 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12758-12764 +std::optional MorePreferableByCUDA = +CheckCUDAPreference(FD, Result); +// If FD has different CUDA preference than Result. +if (MorePreferableByCUDA) { +

[PATCH] D154300: [CUDA][HIP] Fix template argument deduction

2023-07-02 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tra, rsmith. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. yaxunl requested review of this revision. nvcc allows using std::malloc and std::free in device code. When std::malloc or std::free is passed as a