This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG92f4bf268998: Fix aggregate CTAD with string literals adding
extra const (authored by MitalAshok, committed by ychen).
Repository:
rG LLVM Github
ychen accepted this revision.
ychen added a comment.
This revision is now accepted and ready to land.
LGTM. Thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154301/new/
https://reviews.llvm.org/D154301
_
MitalAshok updated this revision to Diff 536648.
MitalAshok edited the summary of this revision.
MitalAshok added a comment.
Add status for CWG2681 and fixed aggregate-deduction-candidate test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154301/new
ychen added a comment.
`clang/test/SemaTemplate/aggregate-deduction-candidate.cpp` seems need updates.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154301/new/
https://reviews.llvm.org/D154301
___
cfe-c
ychen added a comment.
Thanks for catching this. The change LGTM. I think this is
https://wg21.link/cwg2681. Could you please move the test to
`clang/test/CXX/drs/dr26xx.cpp` and keep only these tests that are in the DR?
Then you could run `clang/www/make_cxx_dr_status` to update
`clang/www/cx
MitalAshok created this revision.
Herald added a project: All.
MitalAshok edited the summary of this revision.
MitalAshok added reviewers: ychen, aaron.ballman, cor3ntin.
MitalAshok added a subscriber: cfe-commits.
MitalAshok retitled this revision from "Fix CTAD with string literals adding
extra
