This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd0be47c51cfd: [clang][dataflow] Make
`runDataflowReturnError()` a non-template function. (authored by mboehme).
Repository:
rG LLVM Github
mboehme updated this revision to Diff 537061.
mboehme added a comment.
Rename `runDataflowReturnError()` as discussed in review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154339/new/
https://reviews.llvm.org/D154339
Files:
gribozavr2 added inline comments.
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:389
/// verify the results.
-template
-llvm::Error
-runDataflowReturnError(llvm::StringRef Code, VerifyResultsT VerifyResults,
- DataflowAnalysisOptions
mboehme added inline comments.
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:389
/// verify the results.
-template
-llvm::Error
-runDataflowReturnError(llvm::StringRef Code, VerifyResultsT VerifyResults,
- DataflowAnalysisOptions
gribozavr2 added inline comments.
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:389
/// verify the results.
-template
-llvm::Error
-runDataflowReturnError(llvm::StringRef Code, VerifyResultsT VerifyResults,
- DataflowAnalysisOptions
mboehme added inline comments.
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:389
/// verify the results.
-template
-llvm::Error
-runDataflowReturnError(llvm::StringRef Code, VerifyResultsT VerifyResults,
- DataflowAnalysisOptions
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:389
/// verify the results.
-template
-llvm::Error
-runDataflowReturnError(llvm::StringRef
mboehme created this revision.
Herald added subscribers: martong, xazax.hun.
Herald added a reviewer: NoQ.
Herald added a project: All.
mboehme requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
It turns out this didn't need to be a template