hubert.reinterpretcast added a comment.
This patch seems to be direct cause of a regression:
https://github.com/llvm/llvm-project/issues/64605.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154359/new/
https://reviews.llvm.org/D154359
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfde5924dcc69: [clang] Reset FP options before template
instantiation (authored by sepavloff).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154359/new/
zahiraam added a comment.
LGTM. Thanks for the patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154359/new/
https://reviews.llvm.org/D154359
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sepavloff added inline comments.
Comment at: clang/test/CodeGen/fp-template.cpp:28
+// CHECK-LABEL: define {{.*}} float @_ZN7PR6354211stable_sortIiEEffT_(
+// CHECK: fadd float
+
zahiraam wrote:
> Shouldn't we be expecting a constraint add here?
Yes, you
sepavloff updated this revision to Diff 539597.
sepavloff added a comment.
Fix test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154359/new/
https://reviews.llvm.org/D154359
Files:
clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
zahiraam added inline comments.
Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:5093
+FpPragmaStack.CurrentValue = FPOptionsOverride();
+
if (addInstantiatedParametersToScope(Function, PatternDecl, Scope,
This seems to be fixing the crash.
sepavloff created this revision.
sepavloff added reviewers: rsmith, rjmccall, aaron.ballman, efriedma.
Herald added a project: All.
sepavloff requested review of this revision.
Herald added a project: clang.
AST nodes that may depend on FP options keep them as a difference
relative to the options
