This revision was automatically updated to reflect the committed changes.
Closed by commit rG1af0e34477a3: [clangd][c++20] Drop first template argument
in code completion in some… (authored by massberg).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:484
+ S.Signature = RemoveFirstTemplateArg(S.Signature);
+ S.SnippetSuffix =
massberg updated this revision to Diff 537163.
massberg marked 2 inline comments as done.
massberg added a comment.
Add test case that isn't correctly handled yet and add FIXME comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154450/new/
massberg marked 7 inline comments as done.
massberg added inline comments.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:327
+return "";
+ return "<" + Signature.substr(FirstComma + 2);
+}
sammccall wrote:
> I don't love the arithmetic, the
massberg updated this revision to Diff 537161.
massberg added a comment.
Update code by resolving comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154450/new/
https://reviews.llvm.org/D154450
Files:
sammccall added a comment.
Cool! This makes sense, and is much cheaper than actually working out how to
render the abbreviated arg list and store it in the index.
Nice that TopLevel gives us some of these contexts, but I suspect it's not all.
(If not, it's fine to handle just this case for now
massberg created this revision.
massberg added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
massberg requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
In
