This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2e7d711a1061: [clang] Add serialization support for the
DynamicAllocLValue variant of APValue… (authored by nridge).
Repository:
rG LLVM Github
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks, looks good to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154471/new/
https://reviews.llvm.org/D154471
nridge updated this revision to Diff 542793.
nridge added a comment.
Add testcase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154471/new/
https://reviews.llvm.org/D154471
Files:
clang/include/clang/AST/PropertiesBase.td
nridge planned changes to this revision.
nridge added a comment.
Thank you for the suggested testcase!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154471/new/
https://reviews.llvm.org/D154471
___
hokein added a comment.
I gave it a try, here is a testcase that triggers the crash
// clang -cc1 -emit-pch -o /tmp/t.pch /tmp/t.cpp
#ifndef HEADER
#define HEADER
struct A { int *p; };
const A = A{ new int(10) };
#endif
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
hokein added a comment.
I believe the fix is correct.
Though the fix has been verified by a real-world example, I think it would be
nice to get a reproducible testcase. Looking at the stacktrace:
- the crash occurs during the pch deserialization
- and we miss handling the case where LValue
nridge created this revision.
Herald added a project: All.
nridge updated this revision to Diff 537970.
nridge added a comment.
nridge edited the summary of this revision.
Herald added a subscriber: kadircet.
nridge published this revision for review.
Herald added subscribers: cfe-commits,
