[PATCH] D154486: [Clang] Fix a crash when trying to initialize an invalid aggregate.

2023-07-05 Thread Corentin Jabot via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bc7f3fb9367: [Clang] Fix a crash when trying to initialize an invalid aggregate. (authored by cor3ntin). Repository: rG LLVM Github Monorepo

[PATCH] D154486: [Clang] Fix a crash when trying to initialize an invalid aggregate.

2023-07-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154486/new/ https://reviews.llvm.org/D154486

[PATCH] D154486: [Clang] Fix a crash when trying to initialize an invalid aggregate.

2023-07-05 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 537319. cor3ntin added a comment. Address Aaron's Feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154486/new/ https://reviews.llvm.org/D154486 Files: clang/lib/Sema/SemaInit.cpp

[PATCH] D154486: [Clang] Fix a crash when trying to initialize an invalid aggregate.

2023-07-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Precommit CI found issues with the newly added test that should be addressed. Comment at: clang/docs/ReleaseNotes.rst:633-634 (`#63012 `_) +- Fix a crash when trying to parentheses-initialize

[PATCH] D154486: [Clang] Fix a crash when trying to initialize an invalid aggregate.

2023-07-05 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We did not return an error when failing to producing a valid expression when performing the initialization of an