john.brawn added inline comments.
Comment at: clang/unittests/AST/UnresolvedSetTest.cpp:11
+};
+} // namespace clang
+
jroelofs wrote:
> jroelofs wrote:
> > This ODR violation broke the build for me because it's picking up the
> > definition from Decl.h instead
jroelofs added inline comments.
Comment at: clang/unittests/AST/UnresolvedSetTest.cpp:11
+};
+} // namespace clang
+
jroelofs wrote:
> This ODR violation broke the build for me because it's picking up the
> definition from Decl.h instead of this one.
>
> ```
>
jroelofs added inline comments.
Comment at: clang/unittests/AST/UnresolvedSetTest.cpp:11
+};
+} // namespace clang
+
This ODR violation broke the build for me because it's picking up the
definition from Decl.h instead of this one.
```
john.brawn added a comment.
Unfortunately my fix then broke builds using MSVC. Hopefully fixed for real in
https://reviews.llvm.org/rG25784cd6a962.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154502/new/
https://reviews.llvm.org/D154502
john.brawn added a comment.
The test I added here caused failures in buildbots that build with -Wall
-Werror, fixed in https://reviews.llvm.org/rG258322105892.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154502/new/
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4ade8b7ed997: [AST] Fix bug in UnresolvedSet::erase of last
element (authored by john.brawn).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154502/new/
https://reviews.llvm.org/D154502
john.brawn created this revision.
john.brawn added reviewers: dexonsmith, rsmith, rjmccall.
Herald added a project: All.
john.brawn requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
UnresolvedSet::erase works by popping the last element then
