[PATCH] D154568: [Clang][OpenMP] GPU simd directive code generation

doru1004 added a comment. In D154568#4528274 , @efwright wrote: > Dropping off a simple test case. If this looks about what you would expect > for the tests I have a couple more involved ones that I can repurpose and add > in. For more complex tests we

[PATCH] D154568: [Clang][OpenMP] GPU simd directive code generation

domada added a comment. Hi, thank you for your contribution. Could you fix assertion failure which was reported by Clang CI ( https://buildkite.com/llvm-project/premerge-checks/builds/166519#01898852-f9c9-4dd2-9933-b32be792c976 ) ? `Assertion failed: OpenMPRuntime != nullptr, file

[PATCH] D154568: [Clang][OpenMP] GPU simd directive code generation

jdoerfert added a comment. In D154568#4528274 , @efwright wrote: > Dropping off a simple test case. If this looks about what you would expect > for the tests I have a couple more involved ones that I can repurpose and add > in. For more complex tests

[PATCH] D154568: [Clang][OpenMP] GPU simd directive code generation

efwright updated this revision to Diff 543540. efwright added a comment. Dropping off a simple test case. If this looks about what you would expect for the tests I have a couple more involved ones that I can repurpose and add in. For more complex tests we have a couple of the benchmark codes

[PATCH] D154568: [Clang][OpenMP] GPU simd directive code generation

jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:1532 + +} + This is in large parts copied from existing code. Can we extract those parts into helper functions instead of duplicating them? Repository: rG LLVM Github

[PATCH] D154568: [Clang][OpenMP] GPU simd directive code generation

jdoerfert added a comment. Do you have tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154568/new/ https://reviews.llvm.org/D154568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org