[PATCH] D154706: [RISCV] Add XLEN width integer type: riscv_int.h

kito-cheng marked an inline comment as done. kito-cheng added inline comments. Comment at: clang/lib/Headers/riscv_int.h:10 + +#ifndef __RISCV_INT_H + craig.topper wrote: > Don't you have to `#define __RISCV_INT_H` after this to make this a complete > include

[PATCH] D154706: [RISCV] Add XLEN width integer type: riscv_int.h

kito-cheng updated this revision to Diff 538497. kito-cheng added a comment. Changes: - Define __RISCV_INT_H Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154706/new/ https://reviews.llvm.org/D154706 Files: clang/lib/Headers/CMakeLists.txt

[PATCH] D154706: [RISCV] Add XLEN width integer type: riscv_int.h

craig.topper added inline comments. Comment at: clang/lib/Headers/riscv_int.h:10 + +#ifndef __RISCV_INT_H + Don't you have to `#define __RISCV_INT_H` after this to make this a complete include guard? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D154706: [RISCV] Add XLEN width integer type: riscv_int.h

kito-cheng updated this revision to Diff 538094. kito-cheng added a comment. Chagnes: - Update header comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154706/new/ https://reviews.llvm.org/D154706 Files: clang/lib/Headers/CMakeLists.txt

[PATCH] D154706: [RISCV] Add XLEN width integer type: riscv_int.h

kito-cheng created this revision. kito-cheng added a reviewer: asb. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng,