[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7228 + } else { +Args.ClaimAllArgs(options::OPT_fgpu_approx_transcendentals); +Args.ClaimAllArgs(options::OPT_fno_gpu_approx_transcendentals); MaskRay wrote: > You can use

[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked 4 inline comments as done. Closed by commit rGe17882430e5c: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals` (authored by yaxunl). Herald added

[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

MaskRay accepted this revision. MaskRay added a comment. Some nits about testing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154797/new/ https://reviews.llvm.org/D154797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7228 + } else { +Args.ClaimAllArgs(options::OPT_fgpu_approx_transcendentals); +Args.ClaimAllArgs(options::OPT_fno_gpu_approx_transcendentals); You can use

[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:1294 +if (!LangOpts.HIP) + Builder.defineMacro("__CLANG_CUDA_APPROX_TRANSCENDENTALS__"); +

[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

yaxunl updated this revision to Diff 538787. yaxunl marked 3 inline comments as done. yaxunl edited the summary of this revision. yaxunl added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, asavonic, sstefan1. revised by comments CHANGES SINCE LAST ACTION

[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7221-7223 +bool UseApproxTranscendentals = false; +if (Args.hasFlag(options::OPT_ffast_math, options::OPT_fno_fast_math, + false))

[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

MaskRay added inline comments. Comment at: clang/test/Driver/hip-options.hip:179 +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -nogpuinc -nogpulib -fgpu-approx-transcendentals \ +// RUN: --cuda-gpu-arch=gfx906 %s 2>&1 | FileCheck -check-prefixes=APPROX %s +

[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

tra added a comment. Looks good in general. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7221-7223 +bool UseApproxTranscendentals = false; +if (Args.hasFlag(options::OPT_ffast_math, options::OPT_fno_fast_math, + false)) ```

[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

yaxunl created this revision. yaxunl added reviewers: tra, MaskRay, b-sumner. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. yaxunl requested review of this revision. Rename `-fcuda-approx-transcendentals` as `-fgpu-approx-transcendentals` and pass it to both device