[PATCH] D154903: clangd: Provide the resource dir via environment variable

sammccall added a comment. D156044 attempts to have clangd always exclude the builtin headers when querying the driver. Would be great to know if this fixes your problem. (But if you're not in a position to try a patch like that, filtering the path out in

[PATCH] D154903: clangd: Provide the resource dir via environment variable

sammccall added a comment. TL;DR: can you try just excluding GCC's resource dir, rather than replacing it with clang's? I think that might solve your problem, and is probably something we should be doing automatically. In D154903#4525329 ,

[PATCH] D154903: clangd: Provide the resource dir via environment variable

madscientist added a comment. Sorry for the delay in replying. I'll try to respond to the various points you made: - I don't quite understand the first bullet, "more ways to initialize the resource dir". As far as I can see there's only one place it's set. If my change is using a

[PATCH] D154903: clangd: Provide the resource dir via environment variable

sammccall added a comment. I'm a little nervous about this. On the one hand it's simple and I want to get you unblocked but: - the more ways to initialize resource dir and the more places this needs to be propagated to, the more likely this is to get out of sync - we might want to remove the

[PATCH] D154903: clangd: Provide the resource dir via environment variable

madscientist added a comment. Thanks for adding Sam. I tried to do this but failed: his Phabricator handle isn't available in CODE_OWNERS.txt and my attempts to add him via his email address failed. I have no Phabricator fu! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154903: clangd: Provide the resource dir via environment variable

nridge added a reviewer: sammccall. nridge added a comment. Looks reasonable to me but Sam should OK this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154903/new/ https://reviews.llvm.org/D154903 ___

[PATCH] D154903: clangd: Provide the resource dir via environment variable

madscientist created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. madscientist published this revision for review. madscientist added a comment. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.