[PATCH] D155094: Refactoring and asserts in LevelIndentTracker. (NFC)

2023-07-17 Thread Sedenion via Phabricator via cfe-commits
Sedeniono added a comment. I don't see how the failed test cases could be my fault; they deal with the address sanitizer. So maybe some one could please commit this to main using `Sedenion <39583823+sedeni...@users.noreply.github.com>`? Thanks! Repository:

[PATCH] D155094: Refactoring and asserts in LevelIndentTracker. (NFC)

2023-07-15 Thread Sedenion via Phabricator via cfe-commits
Sedeniono updated this revision to Diff 540682. Sedeniono added a comment. Implemented review changes suggested by @owenpan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155094/new/ https://reviews.llvm.org/D155094 Files:

[PATCH] D155094: Refactoring and asserts in LevelIndentTracker. (NFC)

2023-07-12 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:92-96 + unsigned LevelIndent = Line.First->OriginalColumn; + if (static_cast(LevelIndent) - Offset >= 0) +LevelIndent -= Offset; + assert(Line.Level <

[PATCH] D155094: Refactoring and asserts in LevelIndentTracker. (NFC)

2023-07-12 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:91 void adjustToUnmodifiedLine(const AnnotatedLine ) { -unsigned LevelIndent = Line.First->OriginalColumn; -if (static_cast(LevelIndent) - Offset >= 0) - LevelIndent -= Offset;

[PATCH] D155094: Refactoring and asserts in LevelIndentTracker. (NFC)

2023-07-12 Thread Sedenion via Phabricator via cfe-commits
Sedeniono created this revision. Sedeniono added reviewers: owenpan, MyDeveloperDay, HazardyKnusperkeks. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added a reviewer: rymiel. Sedeniono requested review of this revision. - adjustToUnmodifiedLine: