[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

anna added a comment. thank you @craig.topper and @pengfei . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155145/new/ https://reviews.llvm.org/D155145 ___ cfe-commits mailing list

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

pengfei added a comment. In D155145#4556178 , @craig.topper wrote: > In D155145#4556157 , @anna wrote: > >> In D155145#4554786 , @anna wrote: >> Can you capture the

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

craig.topper added a comment. In D155145#4556157 , @anna wrote: > In D155145#4554786 , @anna wrote: > >>> Can you capture the values of EAX, EBX, ECX, and EDX after the two calls to >>> getX86CpuIDAndInfoEx that

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

pengfei added a comment. In D155145#4556157 , @anna wrote: > In D155145#4554786 , @anna wrote: > >>> Can you capture the values of EAX, EBX, ECX, and EDX after the two calls to >>> getX86CpuIDAndInfoEx that have

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

anna added a comment. In D155145#4554786 , @anna wrote: >> Can you capture the values of EAX, EBX, ECX, and EDX after the two calls to >> getX86CpuIDAndInfoEx that have 0x7 as the first argument? Maybe there's a >> bug in CPUID on Sandy Bridge. > >

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

pengfei added a comment. Thanks @anna and @craig.topper I think we can dump the value with the simple code $ cat cpuid.c #include #include int main() { unsigned int info[4]; for (int i = 0; i < 2; ++i) { __get_cpuid_count(7, 1, info, info + 1, info + 2, info + 3);

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

anna added a comment. > Can you capture the values of EAX, EBX, ECX, and EDX after the two calls to > getX86CpuIDAndInfoEx that have 0x7 as the first argument? Maybe there's a bug > in CPUID on Sandy Bridge. Sure, on the original code before the patch you suggested right? The two calls are:

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

craig.topper added a comment. In D155145#4553922 , @anna wrote: > In D155145#4551621 , @craig.topper > wrote: > >> In D155145#4551526 , @anna wrote: >> >>> In

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

anna added a comment. In D155145#4551621 , @craig.topper wrote: > In D155145#4551526 , @anna wrote: > >> In D155145#4544068 , @pengfei >> wrote: >> >>> In

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

craig.topper added a comment. In D155145#4551526 , @anna wrote: > In D155145#4544068 , @pengfei wrote: > >> In D155145#4543326 , @anna wrote: >> >>> We see a crash

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

anna added a comment. In D155145#4544068 , @pengfei wrote: > In D155145#4543326 , @anna wrote: > >> We see a crash bisected to this patch about using an illegal instruction. >> Here's the CPUInfo for the

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

pengfei added a comment. In D155145#4543326 , @anna wrote: > We see a crash bisected to this patch about using an illegal instruction. > Here's the CPUInfo for the machine: > > CPU info: > current cpu id: 22 > total 32(physical cores 16) (assigned

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

anna added a comment. We see a crash bisected to this patch about using an illegal instruction. Here's the CPUInfo for the machine: CPU info: current cpu id: 22 total 32(physical cores 16) (assigned logical cores 32) (assigned physical cores 16) (assigned_sockets:2 of 2) (8 cores per

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155145/new/ https://reviews.llvm.org/D155145

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

FreddyYe added a comment. ping... Anyone help accept? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155145/new/ https://reviews.llvm.org/D155145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

RKSimon added inline comments. Comment at: clang/lib/Headers/avxvnniint16intrin.h:26 + +static __inline__ __m128i __DEFAULT_FN_ATTRS128 _mm_dpwsud_epi32(__m128i __A, + __m128i __B, doxygen