This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcf10061da75e: [clang][Interp] Fully serialize Floating
values to bytes (authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D1
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/Source.h:63-64
/// Pointer into the code owned by a function.
+public:
const std::byte *Ptr;
};
aaron.ballman wrote:
> Any chance we can use friendship here as well, rather than exposing the d
tbaeder updated this revision to Diff 545353.
tbaeder marked 2 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155165/new/
https://reviews.llvm.org/D155165
Files:
clang/lib/AST/Interp/ByteCodeEmitter.cpp
clang/lib/AST/Interp/Disasm.cpp
clang/lib/AST/Interp/Fl
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from some small nits.
Comment at: clang/lib/AST/Interp/Source.h:63-64
/// Pointer into the code owned by a function.
+public:
const std::byte *
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155165/new/
https://reviews.llvm.org/D155165
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155165/new/
https://reviews.llvm.org/D155165
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This commit is a bit ugly at the moment since I'm gath
