michaelplatings added a comment.
> some nasty and repetitive regexes
Yes, it's the same for Arm architecture extensions. Petr & I went back and
forth on this for a long time. See discussion here to understand Petr's
concerns: https://discourse.llvm.org/t/rfc-multilib/67494/23
CHANGES SINCE
Joe updated this revision to Diff 543440.
Joe added a comment.
Add default ABI to multilib flags if none supplied
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155294/new/
https://reviews.llvm.org/D155294
Files:
clang/include/clang/Driver/ToolChain.h
clang/lib/Driver/ToolChain.cpp
Joe added a comment.
> Theoretically, I think this matching of multilibs could be done without the
> need for multilib.yaml, but it is indeed much easier considering the logic is
> already there.
Actually, I retract this statement. There would be no way of knowing what the
default library is
michaelplatings added a comment.
Hi Joe, it's nice to see multilib.yaml getting some adoption :)
> For the RISCVMultilibFlags, the mabi flag is used in combination with all the
> march extension features (e.g +m). Notably, this doesn't align with the
> current arm/aarch64 multilib flags, which
Joe created this revision.
Joe added reviewers: michaelplatings, kito-cheng.
Joe added a project: clang.
Herald added subscribers: jobnoorman, luke, shiva0217, VincentWu, vkmr,
frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna,
psnobl, abidh, jocewei, PkmX, the_o,
