[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fc6fa97edb6: [clang][AST] TextNodeDumper learned to output exception specifications (authored by strimo378). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D155383#4576302 , @strimo378 wrote: > I added a test case for demonstrating `NoexceptExpr` and `Exceptions` output. > I don't know ho

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

strimo378 added a comment. I added a test case for demonstrating `NoexceptExpr` and `Exceptions` output. I don't know how to produce a FunctionProtoType output with ExceptionSourceDecl and ExceptionSourceTemplate. typedef/using is the only way I know to output types for the current AST dump and

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

strimo378 updated this revision to Diff 548964. strimo378 added a comment. Added test cases and applied review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155383/new/ https://reviews.llvm.org/D155383 Files: clang/lib/AST/TextNodeDump

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

aaron.ballman added a comment. In D155383#4507928 , @strimo378 wrote: > There are many ast-dump tests about decls but there are nearly no other type > tests. We should still be adding tests for these changes, to ensure we don't regress the behavior lat

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

strimo378 added a comment. There are many ast-dump tests about decls but there are nearly no other type tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155383/new/ https://reviews.llvm.org/D155383

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

shafik added a comment. I think we at least need some tests for this, looks like we have the AST tests in `clang/test/AST/ast-dump*` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155383/new/ https://reviews.llvm.org/D155383 __

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

strimo378 created this revision. strimo378 added reviewers: aaron.ballman, hazohelet, stephenkelly. strimo378 added a project: clang. Herald added a project: All. strimo378 requested review of this revision. Herald added a subscriber: cfe-commits. Extended TextNodeDumper::VisitFunctionProtoType to