[PATCH] D155506: [clang][JumpDiagnostics] use StmtClass rather than dyn_cast chain NFC

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. no worries then Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155506/new/ https://reviews.llvm.org/D155506 ___ cfe-commits

[PATCH] D155506: [clang][JumpDiagnostics] use StmtClass rather than dyn_cast chain NFC

rjmccall added a comment. In D155506#4508176 , @gribozavr2 wrote: > I'm not sure it is actually an anti-pattern. `dyn_cast` will transparently > handle subclasses, should any be added in the future, but a switch wouldn't. Yeah, I don't think we have a

[PATCH] D155506: [clang][JumpDiagnostics] use StmtClass rather than dyn_cast chain NFC

gribozavr2 added a comment. I'm not sure it is actually an anti-pattern. `dyn_cast` will transparently handle subclasses, should any be added in the future, but a switch wouldn't. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155506/new/

[PATCH] D155506: [clang][JumpDiagnostics] use StmtClass rather than dyn_cast chain NFC

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Avoid the anti-pattern of: if dyn_cast: ... elif dyn_cast: ... elif dyn_cast: ... And