[PATCH] D155509: Revert "Remove rdar links; NFC"

2023-07-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D155509#4511568 , @jroelofs wrote: > Do you think this and the other patch are good candidates for > `.git-blame-ignore-revs` entries? I think so, yes. (I didn't add the original commit to the ignore list because I

[PATCH] D155509: Revert "Remove rdar links; NFC"

2023-07-18 Thread Jon Roelofs via Phabricator via cfe-commits
jroelofs added a comment. Do you think this and the other patch are good candidates for `.git-blame-ignore-revs` entries? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155509/new/ https://reviews.llvm.org/D155509

[PATCH] D155509: Revert "Remove rdar links; NFC"

2023-07-17 Thread Mehdi AMINI via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0ac46e69d7a: Revert Remove rdar links; NFC (authored by mehdi_amini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155509: Revert "Remove rdar links; NFC"

2023-07-17 Thread Chris Lattner via Phabricator via cfe-commits
lattner accepted this revision. lattner added a comment. Thank you, this should have been reverted immediately when concerns were raised. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155509/new/ https://reviews.llvm.org/D155509

[PATCH] D155509: Revert "Remove rdar links; NFC"

2023-07-17 Thread Tom Stellard via Phabricator via cfe-commits
tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155509/new/ https://reviews.llvm.org/D155509

[PATCH] D155509: Revert "Remove rdar links; NFC"

2023-07-17 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini created this revision. mehdi_amini added reviewers: lattner, aaron.ballman. Herald added subscribers: steakhal, jdoerfert, martong, pengfei, arphaman. Herald added a reviewer: NoQ. Herald added a project: All. mehdi_amini requested review of this revision. Herald added subscribers: