[PATCH] D155784: [X86] Update features for sierraforest, grandridge

2023-07-24 Thread Freddy, Ye via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5cc4b1059b28: [X86] Update features for sierraforest, grandridge (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D155784: [X86] Update features for sierraforest, grandridge

2023-07-20 Thread Kan Shengchen via Phabricator via cfe-commits
skan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155784/new/ https://reviews.llvm.org/D155784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D155784: [X86] Update features for sierraforest, grandridge

2023-07-20 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 542476. FreddyYe marked an inline comment as done. FreddyYe added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155784/new/ https://reviews.llvm.org/D155784 Files:

[PATCH] D155784: [X86] Update features for sierraforest, grandridge

2023-07-20 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:2496 // CHECK_SRF_M32: #define __PTWRITE__ 1 +// CHECK_GRR_M32: #define __RAOINT__ 1 // CHECK_SRF_M32: #define __RDPID__ 1 This is easy to be confused. How about add a

[PATCH] D155784: [X86] Update features for sierraforest, grandridge

2023-07-20 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe created this revision. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo