This revision was automatically updated to reflect the committed changes.
Closed by commit rG16b5e1897b7e: [include-cleaner] Loose matching for verbatim
headers (authored by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155819/new/
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/include-cleaner/lib/Types.cpp:171-173
+for (unsigned I : BySpellingAlternate.lookup(Spelling))
+ if
sammccall added inline comments.
Comment at: clang-tools-extra/include-cleaner/lib/Types.cpp:110-112
+ while (!P.empty() && path::is_separator(P.back()))
+P.pop_back();
+ return P;
kadircet wrote:
> nit: `return P.rtrim('/');` // only separator we can
sammccall updated this revision to Diff 544323.
sammccall marked 6 inline comments as done.
sammccall added a comment.
address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155819/new/
https://reviews.llvm.org/D155819
Files:
kadircet added inline comments.
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:198
llvm::StringMap> BySpelling;
+ llvm::StringMap> BySpellingAlternate;
llvm::DenseMap> ByFile;
maybe add a comment saying that these
sammccall added a comment.
(ping - also happy to send this to someone else if you prefer!)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155819/new/
https://reviews.llvm.org/D155819
___
cfe-commits
sammccall updated this revision to Diff 542444.
sammccall added a comment.
Herald added a subscriber: ormris.
clean up some leftovers
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155819/new/
https://reviews.llvm.org/D155819
Files:
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added a project: All.
sammccall requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
A verbatim header usually corresponds to a symbol from a header with
