[PATCH] D155826: [HIP][Clang][Preprocessor][RFC] Add preprocessor support for C++ Parallel Algorithm Offload

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0f8748d448b: [HIP][Clang][Preprocessor] Add Preprocessor support for `hipstdpar` (authored by AlexVlx). Changed prior to commit:

[PATCH] D155826: [HIP][Clang][Preprocessor][RFC] Add preprocessor support for C++ Parallel Algorithm Offload

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155826/new/ https://reviews.llvm.org/D155826 ___ cfe-commits mailing list

[PATCH] D155826: [HIP][Clang][Preprocessor][RFC] Add preprocessor support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 552952. AlexVlx added a comment. Define the interpose macro iff in interpose mode. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155826/new/ https://reviews.llvm.org/D155826 Files: clang/lib/Frontend/InitPreprocessor.cpp

[PATCH] D155826: [HIP][Clang][Preprocessor][RFC] Add preprocessor support for C++ Parallel Algorithm Offload

yaxunl added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:590 + Builder.defineMacro("__HIPSTDPAR__"); + if (!LangOpts.CUDAIsDevice) +Builder.defineMacro("__HIPSTDPAR_INTERPOSE_ALLOC__"); We usually prefer defining the

[PATCH] D155826: [HIP][Clang][Preprocessor][RFC] Add preprocessor support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 552561. AlexVlx retitled this revision from "[Clang][Preprocessor][RFC] Add preprocessor support for C++ Parallel Algorithm Offload" to "[HIP][Clang][Preprocessor][RFC] Add preprocessor support for C++ Parallel Algorithm Offload". AlexVlx added a comment.