Fznamznon abandoned this revision.
Fznamznon added a comment.
Oh shoot, I trusted the tool too much to not double check that the copy ctor is
already deleted. Thank you for the catch and for the bug report.
I'll abandon this change then.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
tahonermann added a comment.
> I agree. I'll try to isolate a reproducible test case and report it to the
> vendor.
Done.
I'm ambivalent with regard to keeping or discarding the proposed change, but
the static analysis issue should be triaged as a false positive.
Repository:
rG LLVM
tahonermann added a comment.
> there's no bug being fixed which makes me think this should go back to the
> static analysis vendor to report this as a false positive.
I agree. I'll try to isolate a reproducible test case and report it to the
vendor.
Repository:
rG LLVM Github Monorepo
aaron.ballman added a comment.
I'm not opposed, but the copy ctor and copy assignment operators are already
deleted by default in this case (e.g., the class has data members with deleted
copy constructors). So I agree this is an NFC change, but there's no bug being
fixed which makes me think
Fznamznon created this revision.
Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus,
a.sidorin, baloghadamsoftware.
Herald added a project: All.
Fznamznon requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
