This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
sammccall marked 2 inline comments as done.
Closed by commit rGd97a3419c0a3: [clangd] Loose include-cleaner matching for
verbatim headers (authored by sammccall).
sammccall marked 4 inline comments as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/Headers.h:179
+ // All paths are canonical (FileManager::getCanonicalPath()).
+ std::vector SearchPathCanonical;
+
kadircet wrote:
>
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks!
Comment at: clang-tools-extra/clangd/Hover.cpp:1250
const SourceManager = AST.getSourceManager();
- const auto =
- convertIncludes(SM,
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/Headers.cpp:185
+ // The entries will be the same, but canonicalizing to find out is expensive!
+ if (SearchPathCanonical.empty()) {
+for (const auto :
kadircet wrote:
> nit: early exit
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/Headers.cpp:185
+ // The entries will be the same, but canonicalizing to find out is expensive!
+ if (SearchPathCanonical.empty()) {
+for (const auto :
nit: early exit
sammccall updated this revision to Diff 542653.
sammccall added a comment.
Herald added a subscriber: ChuanqiXu.
extract isPreferredProvider helper
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155878/new/
https://reviews.llvm.org/D155878
Files:
sammccall created this revision.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
This updates clangd to take advantage
