probinson added a comment.
See https://reviews.llvm.org/D156571
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155991/new/
https://reviews.llvm.org/D155991
___
cfe-commits mailing list
probinson added a comment.
> Any memory usage measurements to check this doesn't have a significant
> adverse impact by copying all the strings?
Not actual measurements, no; but intuitively the size should not be much
greater than the size of the filename entries in the .debug_line section for
nikic added a comment.
FYI this is a 0.5% compile-time regression on `O0` builds
(https://llvm-compile-time-tracker.com/compare.php?from=69593aa5c054cec6be6b822c073ccdc63748a68d=7abb5fc618cec66841a8280d2a099a4c9c8cb91b=instructions:u).
Is that expected?
Repository:
rG LLVM Github Monorepo
dblaikie added a comment.
Any memory usage measurements to check this doesn't have a significant adverse
impact by copying all the strings? (or performance by having to do string
rather than pointer equality comparisons?)
Could/should we do the lookup on the CU filename before it goes into the
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7abb5fc618ce: [DWARF] Make sure file entry for artificial
functions has an MD5 checksum (authored by probinson).
Herald added a project: clang.
probinson added a comment.
The fix is straightforward but the test was surprisingly tricky; I had to add
the -main-file-name option to keep one of the DIFile's from ending up as
``.
I'm still befuddled about why there are two DIFile entries, when the
DIFileCache clearly has only one. The
probinson created this revision.
probinson added reviewers: dblaikie, aprantl.
probinson added a project: debug-info.
Herald added a project: All.
probinson requested review of this revision.
The DIFile cache was keyed on a string pointer instead of string content,
which was causing misses and
