[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

steven_wu added a comment. In D156014#4567446 , @jhuber6 wrote: > In D156014#4567363 , @steven_wu > wrote: > >> This breaks macOS bot: >>

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

jhuber6 added a comment. In D156014#4567363 , @steven_wu wrote: > This breaks macOS bot: > https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/36900/testReport/junit/Clang/SemaCUDA/alias_cu/ I should've fixed that already. Is it

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

steven_wu added a comment. This breaks macOS bot: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/36900/testReport/junit/Clang/SemaCUDA/alias_cu/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156014/new/

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ba9aec38faa: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets (authored by jhuber6). Repository: rG LLVM Github Monorepo

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

jhuber6 updated this revision to Diff 547871. jhuber6 added a comment. Update to check the SDK version. Permit this if there is not passed in SDK version so that freestanding targets can still target CUDA and assume it's supported. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

tra added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1995 } - if (S.Context.getTargetInfo().getTriple().isNVPTX()) { -S.Diag(AL.getLoc(), diag::err_alias_not_supported_on_nvptx); jhuber6 wrote: > jhuber6 wrote: > > tra wrote: > > > tra

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156014/new/ https://reviews.llvm.org/D156014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

jhuber6 added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1995 } - if (S.Context.getTargetInfo().getTriple().isNVPTX()) { -S.Diag(AL.getLoc(), diag::err_alias_not_supported_on_nvptx); jhuber6 wrote: > tra wrote: > > tra wrote: > > >

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

jhuber6 added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1995 } - if (S.Context.getTargetInfo().getTriple().isNVPTX()) { -S.Diag(AL.getLoc(), diag::err_alias_not_supported_on_nvptx); tra wrote: > tra wrote: > > Allowing or not

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

tra added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1995 } - if (S.Context.getTargetInfo().getTriple().isNVPTX()) { -S.Diag(AL.getLoc(), diag::err_alias_not_supported_on_nvptx); tra wrote: > Allowing or not `noreturn` depends on the

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

tra added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1995 } - if (S.Context.getTargetInfo().getTriple().isNVPTX()) { -S.Diag(AL.getLoc(), diag::err_alias_not_supported_on_nvptx); Allowing or not `noreturn` depends on the CUDA version

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

jhuber6 created this revision. jhuber6 added reviewers: tra, arsenm, jlebar, kushanam, aaron.ballman, yaxunl, jdoerfert. Herald added subscribers: mattd, gchakrabarti, asavonic, jeroen.dobbelaere. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: