[PATCH] D156045: [clang][Interp] Enable existing source_location tests

hazohelet added a comment. @tbaeder Now it's working correctly. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156045/new/ https://reviews.llvm.org/D156045 ___ cfe-commits mailing list

[PATCH] D156045: [clang][Interp] Enable existing source_location tests

tbaeder added a comment. @hazohelet Thanks for noticing. Should be fixed via https://github.com/llvm/llvm-project/commit/f8074942c5a6f266abb1c4d1465a4d8115b22d43. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156045/new/

[PATCH] D156045: [clang][Interp] Enable existing source_location tests

hazohelet added a comment. I was rebasing D155064 locally and saw test failures for the new interpreter in this file. The cause seems to me that the new interpreter is not handling some cases of `SourceLocExpr` correctly when they appear inside

[PATCH] D156045: [clang][Interp] Enable existing source_location tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e5809e7e7bc: [clang][Interp] Enable existing source_location tests (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D156045: [clang][Interp] Enable existing source_location tests

cor3ntin accepted this revision. cor3ntin added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaCXX/source_location.cpp:764-768 +#if defined(USE_CONSTEVAL) && !defined(NEW_INTERP) static_assert(test_init_capture() == __LINE__ - 4);

[PATCH] D156045: [clang][Interp] Enable existing source_location tests

tbaeder added inline comments. Comment at: clang/test/SemaCXX/source_location.cpp:764-768 +#if defined(USE_CONSTEVAL) && !defined(NEW_INTERP) static_assert(test_init_capture() == __LINE__ - 4); #else static_assert(test_init_capture() == __LINE__ ); #endif

[PATCH] D156045: [clang][Interp] Enable existing source_location tests

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As requested. This depends on a few other patches