cor3ntin added a comment.
@MitalAshok Do you need me to land that for you> If so, what email should i use?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156064/new/
https://reviews.llvm.org/D156064
___
MitalAshok updated this revision to Diff 544673.
MitalAshok added a comment.
wording of changelog
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156064/new/
https://reviews.llvm.org/D156064
Files:
clang/docs/ReleaseNotes.rst
cor3ntin added inline comments.
Comment at: clang/docs/ReleaseNotes.rst:111
+- Fix CTAD for ``std::initializer_list``. This allows
+ ``std::initializer_list{1, 2, 3}`` to be a ``std::initializer_list``
+ as intended.
Repository:
rG LLVM Github Monorepo
cor3ntin accepted this revision.
cor3ntin added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156064/new/
https://reviews.llvm.org/D156064
MitalAshok updated this revision to Diff 544046.
MitalAshok added a comment.
Rebase changelog to clang 18, add more tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156064/new/
https://reviews.llvm.org/D156064
Files:
shafik added a comment.
This makes sense I see that `isStdInitializerList(...)` is used in a lot of
places, this makes me wonder if we need additional test coverage.
I also added some folks for more review visibility.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
MitalAshok updated this revision to Diff 543697.
MitalAshok added a comment.
Remove now unneeded FIXME
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156064/new/
https://reviews.llvm.org/D156064
Files:
clang/docs/ReleaseNotes.rst
MitalAshok created this revision.
Herald added a project: All.
MitalAshok added reviewers: EricWF, CornedBee, erichkeane.
MitalAshok published this revision for review.
MitalAshok added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The implicitly-generated