[PATCH] D156116: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7a8a7d49776: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC… (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156116: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

SixWeining updated this revision to Diff 547711. SixWeining added a comment. add an extra check for when a candidate from detectFAREligibleStructHelper may not be valid Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156116/new/

[PATCH] D156116: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

SixWeining added a comment. In D156116#4530365 , @thakis wrote: > This seems to not build: http://45.33.8.238/linux/113405/step_4.txt (?) Thanks, I have reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156116: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

thakis added a comment. This seems to not build: http://45.33.8.238/linux/113405/step_4.txt (?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156116/new/ https://reviews.llvm.org/D156116 ___ cfe-commits

[PATCH] D156116: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc299efbf284f: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC… (authored by SixWeining). Repository: rG LLVM Github

[PATCH] D156116: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

xen0n accepted this revision. xen0n added a comment. So this one is different than D151298 (I'm very glad that those registers are ultimately saved btw), and solves a real problem. Thanks for the timely catch before LLVM 17 ;-) Repository: rG LLVM Github

[PATCH] D156116: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

xry111 accepted this revision. xry111 added a comment. This revision is now accepted and ready to land. The change itself LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156116/new/ https://reviews.llvm.org/D156116

[PATCH] D156116: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

xry111 added a comment. Ooops. These corner cases are really annoying. I think I should try `make check-gcc check-g++ RUNTESTFLAGS='ALT_CC_UNDER_TEST=clang ALT_CXX_UNDER_TEST=clang++ compat.exp'` in GCC test suite... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156116: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

SixWeining created this revision. SixWeining added reviewers: xry111, xen0n, hev, wangleiat. Herald added subscribers: luismarques, s.egerton, PkmX, simoncook, arichardson. Herald added a project: All. SixWeining requested review of this revision. Herald added subscribers: cfe-commits, wangpc.