This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
ziqingluo-90 marked an inline comment as done.
Closed by commit rGb58e52889808: [-Wunsafe-buffer-usage] Stop generating
incorrect fix-its for variable… (authored by
ziqingluo-90 added a comment.
> Note that your patch doesn't actually address //type// attributes, only
> //declaration// attributes.
It does not address type attribute. We can address it in a follow-up patch.
> So it's likely that we have to give up on unsupported type attributes very
>
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
LGTM!
Yeah I agree that we can eventually support a lot of these incrementally, but
it's great to establish a safe baseline first.
> If there are other specifiers involved, they may be
jkorous added inline comments.
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1387
+// with the source range that is being replaced using fix-its. Especially when
+// we often cannot obtain accruate source ranges of cv-qualified type
+// specifiers.
typo:
ziqingluo-90 created this revision.
ziqingluo-90 added reviewers: NoQ, jkorous, t-rasmud, malavikasamak.
Herald added a project: All.
ziqingluo-90 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
We have to give up on fixing a variable
