[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2df05cd01c17: [RISCV] Support overloaded version ntlh intrinsic function (authored by BeMg). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156221/new/ https://reviews.llvm.org/D156221 ___ cfe-commits mailing list

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

BeMg updated this revision to Diff 546753. BeMg added a comment. Add new line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156221/new/ https://reviews.llvm.org/D156221 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/Headers/riscv_ntlh.h

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

eopXD added inline comments. Comment at: clang/test/CodeGen/RISCV/ntlh-intrinsics/riscv32-zihintntl.c:218 // CHECK: !8 = !{i32 5} \ No newline at end of file Nit: new line here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, and the change seems like is fewer than my exception :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156221/new/

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

BeMg updated this revision to Diff 546324. BeMg added a comment. Use semacheck and CGBuiltin to support overload version functionY Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156221/new/ https://reviews.llvm.org/D156221 Files:

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

craig.topper added a comment. I think another option could be to do this in SemaChecking.cpp where we implement __builtin_riscv_ntl_load and __builtin_riscv_ntl_store. We already do custom type checking there. We could detect the missing argument and give it a default. Repository: rG LLVM

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

BeMg updated this revision to Diff 544645. BeMg added a comment. Add prefix __riscv_ for all marco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156221/new/ https://reviews.llvm.org/D156221 Files: clang/lib/Headers/riscv_ntlh.h

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

kito-cheng added inline comments. Comment at: clang/lib/Headers/riscv_ntlh.h:28 + __builtin_riscv_ntl_load((PTR), __RISCV_NTLH_ALL) +#define SELECT_NTL_LOAD(_1, _2, NAME, ...) NAME + `__SELECT_NTL_LOAD` Comment at:

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

asb added a comment. This seems functionally correct to me, but I'd welcome opinions from others who work more with the C intrinsics on if this is the best way to implement the overloading. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

BeMg created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,