This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf3ce925083d2: [RISCV] Resolve a few bugs in
RISCVVIntrinsicUtils.cpp (authored by 4vtomat).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
kito-cheng accepted this revision.
kito-cheng added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/lib/Sema/SemaRISCVVectorLookup.cpp:136
case Invalid:
+ case Undefined:
llvm_unreachable("Unhandled type.");
4vtomat
4vtomat added inline comments.
Comment at: clang/lib/Sema/SemaRISCVVectorLookup.cpp:136
case Invalid:
+ case Undefined:
llvm_unreachable("Unhandled type.");
eopXD wrote:
> Could we just reuse `Invalid`?
We can't reuse Invalid, since `ScalarType` in
4vtomat updated this revision to Diff 544254.
4vtomat added a comment.
Add a test case for invalid example.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156223/new/
https://reviews.llvm.org/D156223
Files:
eopXD added inline comments.
Comment at: clang/lib/Sema/SemaRISCVVectorLookup.cpp:136
case Invalid:
+ case Undefined:
llvm_unreachable("Unhandled type.");
Could we just reuse `Invalid`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
kito-cheng added a comment.
Does it possible to add a precommit test case to show that we accept unexpected
combination of the type?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156223/new/
https://reviews.llvm.org/D156223
4vtomat created this revision.
Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck,
luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei,
PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27,
shiva0217, kito-cheng, niosHD,
