[PATCH] D156277: [Parser][ObjC] Fix parser crash on nested top-level block with better recovery path

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Small wording suggestion for the comment, but feel free to commit with that change. Comment at: clang/lib/Parse/ParseObjc.cpp:742 -// Eat the identifier. +

[PATCH] D156277: [Parser][ObjC] Fix parser crash on nested top-level block with better recovery path

danix800 updated this revision to Diff 545343. danix800 added a comment. Cleanup spaghetti-ish code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156277/new/ https://reviews.llvm.org/D156277 Files: clang/docs/ReleaseNotes.rst clang/lib/Parse/

[PATCH] D156277: [Parser][ObjC] Fix parser crash on nested top-level block with better recovery path

rjmccall added inline comments. Comment at: clang/docs/ReleaseNotes.rst:125 + out early in case next top-level block occurs as if the previous one is + properly finished. + `Issue 64065 `_ "Fixed a crash when

[PATCH] D156277: [Parser][ObjC] Fix parser crash on nested top-level block with better recovery path

danix800 added inline comments. Comment at: clang/lib/Parse/ParseObjc.cpp:749 + if (!Tok.is(tok::eof)) +ConsumeToken(); break; rjmccall wrote: > danix800 wrote: > > rjmccall wrote: > > > aaron.ballman wrote: > > > > rjmccall wrote: > > > > > a

[PATCH] D156277: [Parser][ObjC] Fix parser crash on nested top-level block with better recovery path

danix800 updated this revision to Diff 545069. danix800 added a comment. Update `clang/docs/ReleaseNotes.rst`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156277/new/ https://reviews.llvm.org/D156277 Files: clang/docs/ReleaseNotes.rst clang/

[PATCH] D156277: [Parser][ObjC] Fix parser crash on nested top-level block with better recovery path

danix800 updated this revision to Diff 545056. danix800 retitled this revision from "[Parser][ObjC] Stop parsing on eof" to "[Parser][ObjC] Fix parser crash on nested top-level block with better recovery path". danix800 edited the summary of this revision. danix800 added a comment. Delay consumi