This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb1193c13a5f9: [clangd] Avoid unexpected desugaring in
isSugaredTemplateParameter (authored by zyounan).
Repository:
rG LLVM Github Monorepo
zyounan updated this revision to Diff 546008.
zyounan added a comment.
Final update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156300/new/
https://reviews.llvm.org/D156300
Files:
clang-tools-extra/clangd/InlayHints.cpp
zyounan updated this revision to Diff 546007.
zyounan added a comment.
.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156300/new/
https://reviews.llvm.org/D156300
Files:
clang-tools-extra/clangd/InlayHints.cpp
nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.
Thanks!
Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:1432
TEST(TypeHints, SubstTemplateParameterAliases) {
+ llvm::StringRef Header = R"cpp(
zyounan added a comment.
Sorry, looks like I messed up with the commits before. Fixed it now.
Comment at: clang-tools-extra/clangd/InlayHints.cpp:207
+
+ // This is a bit tricky: we traverse the type structure and find whether or
+ // not a type in the desugaring process is
zyounan updated this revision to Diff 545922.
zyounan added a comment.
Fix the chaos in the previous update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156300/new/
https://reviews.llvm.org/D156300
Files:
zyounan updated this revision to Diff 545920.
zyounan marked 2 inline comments as done.
zyounan added a comment.
Herald added a project: clang.
Update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156300/new/
https://reviews.llvm.org/D156300
nridge added inline comments.
Comment at: clang-tools-extra/clangd/InlayHints.cpp:198
bool isSugaredTemplateParameter(QualType QT) {
static auto PeelWrappers = [](QualType QT) {
// Neither `PointerType` nor `ReferenceType` is considered as sugared
nit:
zyounan added a comment.
Oops, my apologies for bothering you. Thanks again for the explanation and your
dedication!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156300/new/
https://reviews.llvm.org/D156300
nridge added a comment.
Your patience is appreciated. I have a number of patches in my review queue,
and 3 days is often not a realistic turnaround time for me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156300/new/
zyounan added a comment.
Ping~
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156300/new/
https://reviews.llvm.org/D156300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
zyounan updated this revision to Diff 544252.
zyounan added a comment.
Format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156300/new/
https://reviews.llvm.org/D156300
Files:
clang-tools-extra/clangd/InlayHints.cpp
zyounan created this revision.
zyounan added a reviewer: nridge.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
zyounan requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
This is
13 matches
Mail list logo
